Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Group class with optional sorting #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mecha
Copy link
Member

@mecha mecha commented Jul 17, 2024

The Group class no longer extends Order. It now diverges from Order on the type of its sort property, which is nullable for groups. A null sort on a group will not render the "ASC" or "DESC" keywords in the query, improving compatibility with MySQL and MariaDB versions.

@mecha mecha requested a review from omidakhavans July 17, 2024 10:39
@mecha mecha self-assigned this Jul 17, 2024
Copy link

@omidakhavans omidakhavans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants