Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for CMake build system #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alextwothousand
Copy link

As I mostly use CMake for building C/C++ programs, I thought it would be convenient if a CMakeLists file was available, to allow people to just add_subdirectory this library, or use CMake's FetchContent library.

I also plan on writing C bindings for the kiero library, and so, having CMake support would make it that much easier!

@Rebzzel
Copy link
Owner

Rebzzel commented Oct 12, 2021

Hello, @alextwothousand.
Nice idea, will be implemented in new (>v0.13.0) update.
Have nice day!

@Rebzzel Rebzzel added the enhancement New feature or request label Oct 12, 2021
@Curve
Copy link

Curve commented Oct 18, 2021

I have written a small CMakeLists to make this project work with CMake in a convenient way here: https://github.com/Curve/kiero-cmake

The project allows configuration of the render backend through cmake as well as enabling the usage of minhook through cmake, maybe it can be of help for you ^^

The current implementation of my CMakeLists removes the defines in kiero.h in order to define them itself through the CMakeLists, this is quite a hacky solution but it doesn't work with the current configuration implementation (#8 could be of use here)

@Rebzzel
Copy link
Owner

Rebzzel commented Oct 19, 2021

@Curve, uff, looks good.

The current implementation of my CMakeLists removes the defines in kiero.h in order to define them itself through the CMakeLists, this is quite a hacky solution but it doesn't work with the current configuration implementation (#8 could be of use here)

I think the new implementation (^0.13.0) will solve similar problems (there is a very user-friendly file for this).

PS:

I am very sorry that the update has not been released yet. Unfortunately I'm still very busy to release it.
Please be patient.
Thank you.

@Curve
Copy link

Curve commented Oct 19, 2021

@Rebzzel thanks ^^

And no problem, take all the time you need :D

X-rays5 added a commit to X-rays5/kiero that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants