-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Standard 2.0 support #91
base: master
Are you sure you want to change the base?
Conversation
Probably need to fix travis and appveyor :) |
Are the Owin changes backwards compatible? |
Okay, I've done most of the work getting CI builds going. I've also started on travis, but I haven't managed to get mono + netcore2 to work together. |
Great - there are some breaking changes that can be further discussed. I tried to port the Owin adapter across but it does have breaking changes as it uses the Ideally we'd have a PR to update the core lib to .net core (which is very simple) separate to each of the adapters. |
@PaulParau any thoughts on this? |
We could just use https://github.com/AppMetrics/AppMetrics instead |
Any news about this one ? |
So I have done my best to convert all current adapters etc to the new .NET Standard.
I've decided that a
NotSupportedException
can be thrown if people try to wire up performance counters in a non-full framework (I have targettednet45
andnetstandard2.0
). I would appreciate views on this as this is my first wholesale .NET standard upgrade.Please review and get back to me - happy to tweak etc