Add music control to UI #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Music is not playing automatically when the page loads. - Can be toggled via UI or JS API.
|
I've tried to stick to the JS style of the document. |
Closed
rollandf
approved these changes
Jul 22, 2020
|
Thanks! |
shiramax
pushed a commit
to shiramax/ROSE
that referenced
this pull request
Aug 10, 2020
- Music is not playing automatically when the page loads. - Can be toggled via UI or JS API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, these are the changed I've made after looking at issue:295 and issue:231.