Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic check of homework #369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Acepresso
Copy link
Contributor

Utilized using pytest framework.

Signed-off-by: Guy Hartuv ghartuv@redhat.com

@sleviim
Copy link
Member

sleviim commented Oct 21, 2020

Hi Guy,
Can you please specify on the commit message (title/desc) the exercise number the automation is for?

Signed-off-by: Guy Hartuv <ghartuv@redhat.com>
Copy link
Collaborator

@shiramax shiramax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroman-tic Thanks for your contribution!
The output of the script should be an output that the students/mentors can easily read and understand, do you think you create a nicer output?


Guidelines:
- Student's exercise files should be placed in the same dir as this test.
- Test names are in the form: test_<topic>_<exc>.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not Ideal,
I would change it so I could give a file path to this test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will add that.

Automatic check of student's homework.
Utilized using pytest framework.

Signed-off-by: Guy Hartuv <ghartuv@redhat.com>
@shiramax
Copy link
Collaborator

shiramax commented Nov 9, 2020

@jaroman-tic any news about this PR?

@Acepresso
Copy link
Contributor Author

@shiramax I did not have the capacity to work on it. I do want to complete this task but if it is needed sooner it is ok by me to pass the ownership.

@shiramax
Copy link
Collaborator

@jaroman-tic :(
when do you think you will have the capacity to work on this?

@Acepresso
Copy link
Contributor Author

Sorry @shiramax :(
My team is about to finish a sprint. As soon as I'll know what are my planned tasks for next sprint I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants