Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web design improved, database added #456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OriKaplan0
Copy link

@OriKaplan0 OriKaplan0 commented Mar 26, 2023

index.html changes:

  • Added score boxes.
  • Added game menu.
    game.css changes:
  • Added new styling for the page.
  • Added a game menu styling.
  • Score boxes styled.

score.js file added:

  • Fetched the data from a json file to show and write the scores.
    server/

game.py changes:

  • Added write_json function to update the score and write it into the json.

@sleviim sleviim requested a review from nirs March 26, 2023 13:23
@sleviim
Copy link
Member

sleviim commented Mar 26, 2023

Hi Ori,
Thanks for the PR!
For best results and reviews, please split your PR into smaller pieces (like each bulletin in a different PR).
Also, please share screenshots for the final visualization so we can compare it with the improved look.
You can upload your pictures here: https://imgur.com/ and share the link on the commit message.

Copy link
Member

@sleviim sleviim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriKaplan0 Can you please split to smaller PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants