Explictly test for players car in lane #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yzamir <kobi.zamir@gmail.com>
yaacov
changed the title
nirs
approved these changes
Aug 26, 2023
Not clear to me why the current code is implicit and the new code is explicit. I think both |
yaacov
force-pushed
the
explicit-in-lane
branch
3 times, most recently
from
4a9fcad
to
7b3872f
Compare
yaacov
force-pushed
the
explicit-in-lane
branch
3 times, most recently
from
e9dadd8
to
4da7aab
Compare
nirs
reviewed
Aug 27, 2023
yaacov
force-pushed
the
explicit-in-lane
branch
2 times, most recently
from
28a6bf3
to
fbecad3
Compare
yaacov
force-pushed
the
explicit-in-lane
branch
2 times, most recently
from
66efbe6
to
c0ae8d1
Compare
nirs
reviewed
Aug 27, 2023
yaacov
force-pushed
the
explicit-in-lane
branch
from
c0ae8d1
to
005bb2e
Compare
nirs
reviewed
Aug 27, 2023
Signed-off-by: yzamir <kobi.zamir@gmail.com>
yaacov
force-pushed
the
explicit-in-lane
branch
from
005bb2e
to
ac4613b
Compare
nirs
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When testing if a car is in lane, we do an implicit test, calculating the start and end x value of the player lane, it's better to use explicit calculation to get the lane directly from car position.