Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more idiomatic docstring indentation #481

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

nirs
Copy link
Member

@nirs nirs commented Aug 27, 2023

No description provided.

@nirs nirs requested a review from yaacov August 27, 2023 20:25
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this does not count as 3rd time :-)

@yaacov
Copy link
Member

yaacov commented Aug 27, 2023

p.s.
IMHO we need a dot tile for flake8:

[flake8]
max-line-length = 240

the 80 chars rule is not fun :-)

@nirs
Copy link
Member Author

nirs commented Aug 27, 2023

Nice code have short and sweet names and only few indentation levels and works fine with 80 characters.

But we can switch to black auto formatter, which accepts longer lines for the few case they are needed (e.g. long url in comments) and save the work for formatting the code.

Added #482 with example on how to integrate it.

@nirs nirs merged commit 8ca74dc into RedHat-Israel:master Aug 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants