Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryList): issues/10 missing platform component #385

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventoryList): issues/10 missing platform component

Notes

  • Compensates for an overly aggressive CSS selector used around the inventory paging footer to aid in the Pendo resource center and maintenance display banner.
  • This also pushes the footer paging to the left to compensate for the Pendo resource center icon, see below screenshot

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. Before syncing with this PR log in with a user that has zero inventory listing, typically one of the RHEL architectures.
    1. You should see a white bar at the bottom, and multiple scrollbars on the right
    2. Sync with this PR, rebuild, refresh, the bar should no longer be seen

Example

After

Screen Shot 2020-08-21 at 2 32 14 PM

Screen Shot 2020-08-21 at 2 14 19 PM

Before

Screen Shot 2020-08-21 at 2 35 31 PM

Screen Shot 2020-08-21 at 2 35 56 PM

Updates issue/story

updates #10

@codecov-commenter
Copy link

Codecov Report

Merging #385 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #385   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          68       68           
  Lines        1651     1651           
  Branches      382      382           
=======================================
  Hits         1526     1526           
  Misses        109      109           
  Partials       16       16           
Impacted Files Coverage Δ
src/components/inventoryList/inventoryList.js 88.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bf687...b19cbf5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants