-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): issues/502 add recommendations link #508
Conversation
d96eb1b
to
e32175f
Compare
As of 20201116 temporarily applying the blocked label to this since the link currently doesn't go anywhere. |
Codecov Report
@@ Coverage Diff @@
## qa #508 +/- ##
==========================================
- Coverage 93.47% 93.44% -0.04%
==========================================
Files 74 74
Lines 1963 2379 +416
Branches 496 813 +317
==========================================
+ Hits 1835 2223 +388
- Misses 110 138 +28
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll likely edit the text once we have a writer with a working computer. ;-)
Copy update proposal prior to activating the link. Title: Cloud provider mismatch |
e32175f
to
91760c8
Compare
79d8334
to
01dddb0
Compare
As of 20201202 we were expecting the copy and link to be active, since the link is not we'll go ahead and direct this PR towards the CI branch |
91760c8
to
da8f65a
Compare
Per @jlprevatt updates to copy requested Original:
Change 1
Change 2
Additional comment
|
da8f65a
to
6cad86d
Compare
@ntkathole we're moving forward with getting this into QA in prep for an incremental push to prod-beta |
@jlprevatt this change should go into the document as well. Currently it say "There may be inconsistencies between data in the graph and your inventory display". |
|
@ntkathole Regarding your direct comment to me above, I was initially confused and thought you meant the product doc, but I think you mean the draft of the customer portal article. Yes, if the customer portal article directly quotes the on-screen messaging, the exact text of the message should appear there. |
Looks like we missed your ask @ntkathole ...
That is correct. The more verbose banner is the fallback for when the message has no link available. Now that the link is active this is expected |
What's included
Notes
How to test
Proxy run check
$ yarn
$ yarn start:proxy
https://access.redhat.com/subscription-watch-accuracy
Example
Updates issue/story
#502