Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release 1.3.0, Sync Test to Stage #530

Merged
merged 7 commits into from
Dec 14, 2020
Merged

Draft release 1.3.0, Sync Test to Stage #530

merged 7 commits into from
Dec 14, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Dec 11, 2020

Description

Environment sync

Commits

Features

  1. openshiftView,rhelView issues/490 add tour button (feat(rhelView, openshiftView): issues/490 add tour button #506) (b359ebb)
  2. inventoryList issues/493 product disable guests setting (feat(inventoryList): issues/493 product disable guests setting #510) (3591b07)

Chores

  1. build issues/514 nodejs 12 references to 14 (chore(build): issues/514 update nodejs 12 references to 14 #519) (616414f)
  2. build npm updates (fix(build): npm updates #520) (b9536b8)

Bug Fixes

  1. build npm updates (fix(build): npm updates #520) (e2b0a9c)
  2. build issues/502 add recommendations link (fix(build): issues/502 add recommendations link #508) (6ac6433)
  3. build issues/502 banner message spelling (fix(build): issues/502 banner message spelling #533) (9740707)

Notes

zanewoodfin and others added 6 commits December 3, 2020 15:16
* pageHeader, apply flex columns for button
* openshiftView, rhelView, activate tour button
* inventoryList, hasGuests callback setting
* openshiftView, rhelView, apply basic inventoryList settings
* chartArea, createContainer npm
* select, pagination snapshot props updated
@cdcabrera
Copy link
Member Author

@rblackbu @bclarhk this PR, once merged, reapplies the "Tour" Pendo button to the Prod-beta environment

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #530 (9740707) into stage (01dddb0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            stage     #530      +/-   ##
==========================================
- Coverage   93.47%   93.44%   -0.04%     
==========================================
  Files          74       74              
  Lines        1961     2379     +418     
  Branches      494      813     +319     
==========================================
+ Hits         1833     2223     +390     
- Misses        110      138      +28     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/chartArea/chartArea.js 89.75% <ø> (+0.31%) ⬆️
src/components/openshiftView/openshiftView.js 93.93% <ø> (-1.90%) ⬇️
src/components/rhelView/rhelView.js 90.69% <ø> (-1.90%) ⬇️
src/components/inventoryList/inventoryList.js 90.90% <100.00%> (-2.12%) ⬇️
src/components/pageLayout/pageHeader.js 100.00% <100.00%> (ø)
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.56% <0.00%> (-2.44%) ⬇️
src/services/platformServices.js 97.67% <0.00%> (-2.33%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01dddb0...9740707. Read the comment docs.

@cdcabrera cdcabrera requested review from jlprevatt and removed request for jlprevatt-zz December 12, 2020 07:19
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍 Looks good.

@cdcabrera cdcabrera merged commit 65bda31 into stage Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants