refactor(config): sw-630 architectures, variants as filters #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
sw-630-arch-filter
branch
2 times, most recently
from
c80b644 to
0c22843
Compare
cdcabrera
commented
Dec 2, 2022
cdcabrera
force-pushed
the
sw-630-arch-filter
branch
5 times, most recently
from
b0980a7 to
1d045e6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1006 +/- ##
==========================================
- Coverage 93.22% 93.09% -0.13%
==========================================
Files 118 121 +3
Lines 3851 3970 +119
Branches 1547 1600 +53
==========================================
+ Hits 3590 3696 +106
- Misses 243 256 +13
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
force-pushed
the
sw-630-arch-filter
branch
from
1d045e6 to
958fabe
Compare
cdcabrera
changed the title
cdcabrera
force-pushed
the
sw-630-arch-filter
branch
from
958fabe to
a4fc49c
Compare
cdcabrera
commented
Dec 3, 2022
* locale, toolbar string context * productViewContext, hook, expose all queries * toolbar, generic chip display, filtering * toolbarContext, remove redundant hook * toolbarFields, string context updates * toolbarFieldsArchitecture, Variant, add * config, rhel, satellite architectures, variants * viewReducer, types, generic queries * rhsmServices, emulated archs, variants filter
cdcabrera
force-pushed
the
sw-630-arch-filter
branch
from
a4fc49c to
2c996c8
Compare
cdcabrera
commented
Dec 5, 2022
cdcabrera
added a commit
that referenced
this pull request
Dec 12, 2022
* locale, toolbar string context * dateHelpers, granularity filter string refs * productViewContext, hook, expose all queries * toolbar, generic chip display, filtering * toolbarContext, remove redundant hook * toolbarFields, align string context * toolbarFieldsArchitecture, Variant, add * config, rhel, satellite architectures, variants * viewReducer, types, generic queries * rhsmServices, emulated archs, variants filter
cdcabrera
added a commit
that referenced
this pull request
Dec 13, 2022
* locale, toolbar string context * dateHelpers, granularity filter string refs * productViewContext, hook, expose all queries * toolbar, generic chip display, filtering * toolbarContext, remove redundant hook * toolbarFields, align string context * toolbarFieldsArchitecture, Variant, add * config, rhel, satellite architectures, variants * viewReducer, types, generic queries * rhsmServices, emulated archs, variants filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
architectures, andvariant, query parameter then filter the associated product identifiers at the service level than it is to attempt multi-level redirects. however there will be issues around...product idas part of their context... going this route we may need to expand that context to includearchitecturesandvariantsin the context key/id if copy needs to be even more specific to "product facets" ie. RHEL with architecture RHEL ARM, etcHow to test
Coverage and basic unit test check
$ yarn$ yarn testLocal run check
$ yarn$ yarn startProxy run check
$ yarn$ yarn start:proxyCheck the build
$ yarn$ yarn buildExample
RHEL product display
*copy subject to change
Satellite product display
*copy subject to change
Updates issue/story
sw-630
relates #1014