Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(select): sw-746 select wrapper class to func #1027

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Dec 15, 2022

What's included

  • refactor(select): sw-746 select wrapper class to func

Notes

  • there are no visual changes associated with this update. HOWEVER, this does affect all product views with select/dropdown fields

    • @mirekdlugosz it would be good to specifically check for the data-test attribute. We had to modify how we append it based on PF updates
  • part of a base set of refactors to help with upcoming design updates

  • refactor/perf update for the pf select wrapper. the current select wrapper has some older ways of doing things, and it can be slightly sped up with some of its cycling

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. this update affects ALL product views and ALL selects across Subs
    • confirm that select behavior is working as intended
    • data-test attribute used by QE needs confirmation as not having changed. Unfortunately we had to update some of how this is implemented

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm build checks come back clean

Example

...

Updates issue/story

sw-746

@cdcabrera cdcabrera added 202304 project phase hold labels Dec 15, 2022
@cdcabrera
Copy link
Member Author

As of 20221215 this is a placeholder for updates to the design work, starting with a refactor of the select and table components with updated PF4 components, such as the composable table

@cdcabrera cdcabrera force-pushed the 202212-select-update branch from 17c156e to 96fbc93 Compare December 15, 2022 19:00
@cdcabrera cdcabrera changed the title refactor(select): sw- select wrapper class to func refactor(select): sw-746 select wrapper class to func Dec 15, 2022
@cdcabrera cdcabrera force-pushed the 202212-select-update branch from 96fbc93 to 6e782a6 Compare December 16, 2022 15:38
@cdcabrera cdcabrera force-pushed the 202212-select-update branch 2 times, most recently from c65919c to 40b46d2 Compare January 10, 2023 16:44
@cdcabrera cdcabrera force-pushed the 202212-select-update branch from 40b46d2 to ccd2a1b Compare January 13, 2023 16:19
@cdcabrera cdcabrera force-pushed the 202212-select-update branch from ccd2a1b to f32a8db Compare January 17, 2023 20:52
@cdcabrera cdcabrera marked this pull request as ready for review January 18, 2023 16:09
@cdcabrera cdcabrera removed the hold label Jan 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #1027 (fc42c12) into dev (2bcc043) will decrease coverage by 0.02%.
The diff coverage is 96.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1027      +/-   ##
==========================================
- Coverage   93.12%   93.11%   -0.02%     
==========================================
  Files         122      122              
  Lines        4029     4064      +35     
  Branches     1640     1656      +16     
==========================================
+ Hits         3752     3784      +32     
- Misses        260      263       +3     
  Partials       17       17              
Impacted Files Coverage Δ
src/components/form/select.js 96.87% <96.49%> (-2.07%) ⬇️
src/components/form/formHelpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bcc043...fc42c12. Read the comment docs.

@cdcabrera cdcabrera force-pushed the 202212-select-update branch from fc42c12 to 91820e7 Compare January 18, 2023 22:47
@cdcabrera cdcabrera merged commit 16d730b into RedHatInsights:dev Jan 18, 2023
cdcabrera added a commit that referenced this pull request Jan 24, 2023
* formHelpers, checked bool
* select, class to func, allow dropdowns
* styling, adjust inline, block display
cdcabrera added a commit that referenced this pull request Feb 14, 2023
* formHelpers, checked bool
* select, class to func, allow dropdowns
* styling, adjust inline, block display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants