-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(select): sw-746 select wrapper class to func #1027
Conversation
As of 20221215 this is a placeholder for updates to the design work, starting with a refactor of the select and table components with updated PF4 components, such as the composable table |
17c156e
to
96fbc93
Compare
96fbc93
to
6e782a6
Compare
c65919c
to
40b46d2
Compare
40b46d2
to
ccd2a1b
Compare
ccd2a1b
to
f32a8db
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1027 +/- ##
==========================================
- Coverage 93.12% 93.11% -0.02%
==========================================
Files 122 122
Lines 4029 4064 +35
Branches 1640 1656 +16
==========================================
+ Hits 3752 3784 +32
- Misses 260 263 +3
Partials 17 17
Continue to review full report at Codecov.
|
fc42c12
to
91820e7
Compare
* formHelpers, checked bool * select, class to func, allow dropdowns * styling, adjust inline, block display
* formHelpers, checked bool * select, class to func, allow dropdowns * styling, adjust inline, block display
What's included
Notes
there are no visual changes associated with this update. HOWEVER, this does affect all product views with select/dropdown fields
data-test
attribute. We had to modify how we append it based on PF updatespart of a base set of refactors to help with upcoming design updates
refactor/perf update for the pf select wrapper. the current select wrapper has some older ways of doing things, and it can be slightly sped up with some of its cycling
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Proxy run check
$ yarn
$ yarn start:proxy
Check the build
$ yarn
$ yarn build
Example
...
Updates issue/story
sw-746