Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): sw-728 graph legend, product desc #1034

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(locale): sw-728 graph legend, product desc

Notes

  • remove product description for RHEL and Satellite for
    • graph legends
    • graph tooltip
    • type filter in primary toolbar

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm strings for RHEL and Satellite have the product id/description removed for
    • graph legends
    • graph tooltip
    • type filter in primary toolbar

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2023-01-13 at 10 49 01 AM (2)
Screen Shot 2023-01-13 at 10 49 16 AM (2)

Updates issue/story

sw-728

@cdcabrera cdcabrera added the bug Something isn't working label Jan 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #1034 (9e0cb49) into dev (a0d7d54) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1034   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files         122      122           
  Lines        4029     4029           
  Branches     1640     1640           
=======================================
  Hits         3752     3752           
  Misses        260      260           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d7d54...9e0cb49. Read the comment docs.

@cdcabrera cdcabrera merged commit 6a3c638 into RedHatInsights:dev Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants