feat(i18nHelpers): sw-922 apply testId to copy #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
sw-922-enhance-i18next
branch
from
5273fdf to
0bc5ba8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1079 +/- ##
==========================================
+ Coverage 93.50% 93.53% +0.02%
==========================================
Files 123 123
Lines 4128 4159 +31
Branches 1681 1695 +14
==========================================
+ Hits 3860 3890 +30
- Misses 250 253 +3
+ Partials 18 16 -2
Continue to review full report in Codecov by Sentry.
|
cdcabrera
changed the title
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Mar 14, 2023
…nsights#1079) * helpers, move noopTranslate * i18nHelpers, break apart for testing, noopTranslate
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Mar 14, 2023
cdcabrera
force-pushed
the
sw-922-enhance-i18next
branch
from
0bc5ba8 to
329b10e
Compare
…nsights#1079) * helpers, move noopTranslate * i18nHelpers, break apart for testing, noopTranslate
cdcabrera
force-pushed
the
sw-922-enhance-i18next
branch
from
329b10e to
a195d07
Compare
cdcabrera
added a commit
that referenced
this pull request
Mar 14, 2023
* helpers, move noopTranslate * i18nHelpers, break apart for testing, noopTranslate
cdcabrera
added a commit
that referenced
this pull request
Mar 21, 2023
* helpers, move noopTranslate * i18nHelpers, break apart for testing, noopTranslate
cdcabrera
added a commit
that referenced
this pull request
Mar 21, 2023
cdcabrera
added a commit
that referenced
this pull request
Apr 6, 2023
* helpers, move noopTranslate * i18nHelpers, break apart for testing, noopTranslate
cdcabrera
added a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
testIdprop for i18next to allow either the use of the locale string key on a span with adata-testattribute wrapped around the immediate copy, or a custom identifierHow to test
Coverage and basic unit test check
$ yarn$ yarn testCheck the build
$ yarn$ yarn buildExample
...
Updates issue/story
sw-922