Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platformServices): sw-625 remove onNavigate #1092

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 7, 2023

What's included

  • fix(platformServices): sw-625 remove onNavigate

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. proxy run is limited in its ability to confirm these routing changes
  • confirm left navigation is functioning when navigating between RHEL and OpenShift Subs product views

Example

...

Updates issue/story

sw-625
patch release v2.10.1 rollback

@cdcabrera cdcabrera added the 202304 project phase label Apr 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #1092 (46eb868) into dev (939fd1d) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1092      +/-   ##
==========================================
+ Coverage   93.59%   93.61%   +0.02%     
==========================================
  Files         121      121              
  Lines        4216     4200      -16     
  Branches     1705     1703       -2     
==========================================
- Hits         3946     3932      -14     
+ Misses        253      251       -2     
  Partials       17       17              
Impacted Files Coverage Δ
...components/authentication/authenticationContext.js 100.00% <ø> (+5.71%) ⬆️
src/redux/actions/platformActions.js 100.00% <ø> (ø)
src/redux/types/platformTypes.js 100.00% <ø> (ø)
src/services/platform/platformServices.js 96.87% <ø> (-0.43%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939fd1d...46eb868. Read the comment docs.

@cdcabrera cdcabrera changed the base branch from main to dev April 7, 2023 14:42
* authenticationContext, remove onNavigation callback
* platformActions, remove onNavigation
* redux, platformTypes, remove dispatch type
* services, remove onNavigation
@cdcabrera cdcabrera changed the base branch from dev to main April 7, 2023 14:45
@cdcabrera cdcabrera changed the base branch from main to dev April 7, 2023 14:46
@cdcabrera cdcabrera force-pushed the sw-625-onnavigate branch from f99348c to 46eb868 Compare April 7, 2023 14:46
@cdcabrera cdcabrera marked this pull request as ready for review April 7, 2023 15:18
@cdcabrera cdcabrera merged commit c8693d4 into RedHatInsights:dev Apr 7, 2023
cdcabrera added a commit that referenced this pull request Apr 7, 2023
* authenticationContext, remove onNavigation callback
* platformActions, remove onNavigation
* redux, platformTypes, remove dispatch type
* services, remove onNavigation
cdcabrera added a commit that referenced this pull request Apr 11, 2023
* authenticationContext, remove onNavigation callback
* platformActions, remove onNavigation
* redux, platformTypes, remove dispatch type
* services, remove onNavigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants