Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-748 rhel products to variant filter, 1 of 2 #1096

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-748 rhel products to variant filter

Notes

  • no visual updates associated with this change
  • moves rhel products towards the variant filter. currently rhel uses an architecture filter retooled to appear as variant. this removes the tech debt associated with that patch so we can align all product views towards using a "variant like" filter

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm RHEL and Satellite still have access to the toolbar filter "Variants" and that it functions as expected

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-747 sw-748

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #1096 (21f458a) into dev (3c4de82) will decrease coverage by 0.06%.
The diff coverage is 87.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1096      +/-   ##
==========================================
- Coverage   93.59%   93.54%   -0.06%     
==========================================
  Files         121      122       +1     
  Lines        4214     4212       -2     
  Branches     1704     1715      +11     
==========================================
- Hits         3944     3940       -4     
- Misses        253      255       +2     
  Partials       17       17              
Impacted Files Coverage Δ
src/components/productView/productView.js 90.00% <ø> (-0.33%) ⬇️
src/config/product.rhel.js 90.69% <ø> (ø)
src/redux/actions/rhsmActions.js 100.00% <ø> (ø)
src/redux/types/index.js 100.00% <ø> (ø)
src/redux/types/rhsmTypes.js 100.00% <ø> (ø)
...components/bannerMessages/bannerMessagesContext.js 84.09% <82.05%> (+0.75%) ⬆️
src/components/bannerMessages/bannerMessages.js 92.30% <100.00%> (-7.70%) ⬇️
src/redux/reducers/messagesReducer.js 100.00% <100.00%> (ø)
src/redux/types/messageTypes.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4de82...21f458a. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review April 12, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants