Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-1335 openshift on-demand inventory links #1131

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-1335 openshift on-demand inventory links

Notes

  • disables all on-demand inventory links, see sw-1209 for final resolution

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to /subscriptions/openshift and confirm
    • OpenShift Dedicated variant inventory links no longer activate/display
    • OpenShift metrics variant inventory links no longer activate/display

Example

...

Updates issue/story

sw-1335
related sw-1209 sw-1294 #1129

@cdcabrera cdcabrera added bug Something isn't working 202308 project phase labels Jun 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1131 (82b3a9c) into dev (b2db304) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1131      +/-   ##
==========================================
- Coverage   93.72%   93.67%   -0.05%     
==========================================
  Files         123      123              
  Lines        4303     4301       -2     
  Branches     1767     1767              
==========================================
- Hits         4033     4029       -4     
- Misses        252      254       +2     
  Partials       18       18              
Impacted Files Coverage Δ
src/config/product.openshiftDedicated.js 82.22% <80.00%> (-2.57%) ⬇️
src/config/product.openshiftMetrics.js 81.39% <80.00%> (-2.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2db304...82b3a9c. Read the comment docs.

@cdcabrera cdcabrera merged commit 88b9a6c into RedHatInsights:dev Jun 2, 2023
cdcabrera added a commit that referenced this pull request Jun 2, 2023
* openshift-dedicated, disabled inventory paths, annotation
* openshift-metrics, disabled inventory paths, annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants