Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): sw-1001 rosa string corrections #1145

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(locale): sw-1001 rosa string corrections

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate towards OpenShift and related variants
    • select the ROSA option, confirm the option reads as intended
    • confirm the graph title reads as Hosted control plane instead of Hosted control plan

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2023-06-26 at 2 58 38 PM

Updates issue/story

sw-1001

@cdcabrera cdcabrera added the 202308 project phase label Jun 26, 2023
@cdcabrera cdcabrera merged commit 5082a88 into RedHatInsights:dev Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant