Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 of 3 - refactor(minHeight): sw-1348 class to func #1146

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 28, 2023

What's included

  • refactor(minHeight): sw-1348 class to func

Notes

  • 1 of 3
  • moves from a class to function to improve unit tests before the migration from enzyme

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the graph display renders correctly
    • the metric/on-demand card displays should NOT collapse when graph filters are selected
  5. confirm the inventory display renders correctly
    • the instances and subscriptions inventories should NOT collapse when paging from page to page. the inventory tab card should maintain its height consistently

Example

...

Updates issue/story

related sw-1348
related #1148 #1144

@cdcabrera cdcabrera added the 202308 project phase label Jun 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #1146 (ab7cf21) into dev (ff0a957) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head ab7cf21 differs from pull request most recent head 1dc595b. Consider uploading reports for the commit 1dc595b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1146      +/-   ##
==========================================
+ Coverage   93.53%   93.59%   +0.05%     
==========================================
  Files         123      123              
  Lines        4364     4338      -26     
  Branches     1799     1792       -7     
==========================================
- Hits         4082     4060      -22     
+ Misses        262      258       -4     
  Partials       20       20              
Files Changed Coverage Δ
src/components/inventoryCard/inventoryCard.js 100.00% <ø> (ø)
src/components/minHeight/minHeight.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0a957...1dc595b. Read the comment docs.

@cdcabrera cdcabrera added the blocked Prevented from continuing label Jul 5, 2023
@cdcabrera cdcabrera changed the title refactor(minHeight): sw-1348 class to func 1 of 3 - refactor(minHeight): sw-1348 class to func Jul 17, 2023
@cdcabrera cdcabrera force-pushed the dev branch 2 times, most recently from 254610a to ff0a957 Compare July 24, 2023 21:01
@cdcabrera cdcabrera force-pushed the sw-1348-minheight branch from 05245ee to ab7cf21 Compare July 24, 2023 21:03
@cdcabrera cdcabrera marked this pull request as ready for review July 24, 2023 21:04
@cdcabrera cdcabrera force-pushed the sw-1348-minheight branch from ab7cf21 to 1dc595b Compare July 24, 2023 21:11
@cdcabrera cdcabrera changed the base branch from dev to main July 25, 2023 18:58
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Jul 25, 2023
@cdcabrera cdcabrera force-pushed the sw-1348-minheight branch from 1dc595b to 4dccf66 Compare July 25, 2023 19:08
@cdcabrera cdcabrera merged commit 08e5d14 into RedHatInsights:main Jul 25, 2023
cdcabrera added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants