Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-1570 disable rosa daily totals #1162

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(config): sw-1570 disable rosa daily totals
  • fix(config): sw-1570 reactivate rosa, add to openshift

Notes

  • tries to align the main and dev branches as close as possible since the React 18 prep updates will create a discrepancy in unit test results, possibly a merge conflict. These commits may be appended to the main branch to create a linear history

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm ROSA is accessible under OpenShift as a variant
    • confirm ROSA graph displays only 1 metric card to the left of each graph

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screen Shot 2023-08-03 at 12 15 24 PM

Updates issue/story

sw-1570

@cdcabrera cdcabrera added the 202308 project phase label Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1162 (e9e9341) into dev (9358f95) will increase coverage by 0.01%.
Report is 11 commits behind head on dev.
The diff coverage is 85.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1162      +/-   ##
==========================================
+ Coverage   93.53%   93.55%   +0.01%     
==========================================
  Files         123      123              
  Lines        4364     4357       -7     
  Branches     1799     1795       -4     
==========================================
- Hits         4082     4076       -6     
+ Misses        262      261       -1     
  Partials       20       20              
Files Changed Coverage Δ
src/components/chart/chartHelpers.js 90.36% <ø> (ø)
src/components/i18n/i18n.js 100.00% <ø> (ø)
src/components/inventoryTabs/inventoryTab.js 100.00% <ø> (ø)
src/components/tooltip/tooltip.js 100.00% <ø> (ø)
src/redux/hooks/useReactRedux.js 93.23% <ø> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/components/graphCard/graphCardMetricTotals.js 89.28% <50.00%> (ø)
src/config/product.openshiftDedicated.js 82.22% <75.00%> (ø)
src/config/product.openshiftMetrics.js 81.39% <75.00%> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593b688...e9e9341. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants