Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services): remove deprecated product ids #1166

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 11, 2023

What's included

  • fix(services): remove deprecated product ids

Notes

  • removes rhel, rhel desktop, rhel server, and satellite product IDs
  • applies annotation to explain how product ids are grouped by variant

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate towards rhel and openshift product displays
    • confirm both displays appear as intended
    • confirm ALL variants display as intended

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate towards rhel and openshift product displays
    • confirm both displays appear as intended
    • confirm ALL variants display as intended

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

Related
SWATCH-1605

@cdcabrera cdcabrera added the 202308 project phase label Aug 11, 2023
src/services/README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #1166 (df00ce0) into main (a2c636d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files         121      121           
  Lines        4224     4224           
  Branches     1777     1777           
=======================================
  Hits         3917     3917           
  Misses        278      278           
  Partials       29       29           
Files Changed Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/config/product.rhel.js 82.22% <100.00%> (ø)
src/config/product.satellite.js 83.33% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c636d...df00ce0. Read the comment docs.

@cdcabrera cdcabrera changed the base branch from main to dev August 15, 2023 14:25
@cdcabrera cdcabrera force-pushed the 20230811-productid-cleanup branch from df00ce0 to 31656ab Compare August 15, 2023 15:50
@cdcabrera cdcabrera merged commit fc74595 into RedHatInsights:dev Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants