Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): migrate to react 18 #1189

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 12, 2023

What's included

  • build(deps): migrate to react 18

Notes

  • testing framework required updating to match the 18 "render" load

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm all tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the app loads and products display as intended

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm all tests come back clean

Example

...

Updates issue/story

ongoing
related sw-1348 sw-1537 sw-1689

@cdcabrera cdcabrera added build 202308 project phase labels Sep 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #1189 (f9060a1) into main (6396b12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         123      123           
  Lines        4240     4240           
  Branches     1769     1769           
=======================================
  Hits         3920     3920           
  Misses        301      301           
  Partials       19       19           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6396b12...f9060a1. Read the comment docs.

@cdcabrera cdcabrera force-pushed the main branch 2 times, most recently from 1d65fd8 to af057b4 Compare September 12, 2023 19:44
@cdcabrera cdcabrera changed the title refactor(build): migrate to react 18 build(deps): migrate to react 18 Sep 13, 2023
@cdcabrera cdcabrera marked this pull request as ready for review September 13, 2023 14:59
@cdcabrera cdcabrera added the build:hold Not really blocked. Either updates were just released or local validation required label Sep 13, 2023
@cdcabrera cdcabrera removed the build:hold Not really blocked. Either updates were just released or local validation required label Sep 19, 2023
@cdcabrera cdcabrera merged commit fd4cafe into RedHatInsights:main Sep 19, 2023
cdcabrera added a commit that referenced this pull request Sep 25, 2023
cdcabrera added a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants