Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for swatch-1537, clean up for swatch-1689 PF5 update #1196

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(tableEmpty): sw-1537 aria-label attribute format
  • fix(chartIcon): sw-1689 size prop type warning

Notes

  • couple of fixes that popped up during the work for PF5 sw-1689

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

related #1194 sw-1689 sw-1537

@cdcabrera cdcabrera added bug Something isn't working 202308 project phase labels Sep 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #1196 (8676c91) into main (1312159) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         123      123           
  Lines        4240     4240           
  Branches     1769     1769           
=======================================
  Hits         3920     3920           
  Misses        301      301           
  Partials       19       19           
Files Changed Coverage
src/components/chart/chartIcon.js ø
src/components/table/tableEmpty.js 100.00%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1312159...8676c91. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Sep 22, 2023
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202308 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants