-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dateHelper): swatch-260 remove moment.js from dateHelper #1220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
+ Coverage 92.16% 92.21% +0.04%
==========================================
Files 122 122
Lines 4251 4264 +13
Branches 1786 1790 +4
==========================================
+ Hits 3918 3932 +14
+ Misses 314 312 -2
- Partials 19 20 +1
Continue to review full report in Codecov by Sentry.
|
@vbusch if you have access to @diegomaranhao can help you with accessing these tests, and is up to date with whether they are still running or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All minor stuff, mostly copy. Looks good at the functional level!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor parameter adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
stepped through the combinations against data in staging, ranges appear to maintain the original ranges for standard granularity (daily, weekly, monthly, quarterly), and the additional "ranged granularity" we use for on-demand displays
@vbusch this is an approval without being a github approval, reason, before we merge this update, reviewing a sync between envs for variant work
Signed-off-by: Vanessa Busch <vbusch@redhat.com>
What's included
sw-260 Replace moment.js
Notes
Removed moment.js from the date helper. This is a non functional change. There should be no noticeable UI differences.
TODO: remove it from the other files.
How to test
Coverage and basic unit test check
Proxy run check
Check the build
Updates issue/story
sw-260