Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): SWATCH-1890 activate rhel for x86 HA #1225

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat(config): SWATCH-1890 activate rhel for x86 HA #1225

merged 1 commit into from
Oct 31, 2023

Conversation

Sgitario
Copy link
Contributor

What's included

feat(config): SWATCH-1890 activate rhel for x86 HA

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. yarn start
  3. confirm the product "RHEL for x86 HA" appears in the variant list for RHEL
    confirm ALL API calls now include the product ID rhel-for-x86-ha

Example

Captura de pantalla de 2023-10-31 07-53-26

Updates issue/story

vbusch
vbusch approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@vbusch vbusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cdcabrera will want to review as well.

@cdcabrera cdcabrera added the 202312 project phase label Oct 31, 2023
cdcabrera
cdcabrera approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just a heads up, we've been abbreviating "swatch" to "sw" to save on message length. i'll shorten it on merge

@cdcabrera cdcabrera merged commit 3d21ec1 into RedHatInsights:main Oct 31, 2023
@Sgitario Sgitario deleted the SWATCH-1890 branch October 31, 2023 14:36
@cdcabrera cdcabrera mentioned this pull request Nov 2, 2023
Merged
cdcabrera pushed a commit that referenced this pull request Nov 2, 2023
@Sgitario @cdcabrera
feat(config): sw-1890 activate rhel for x86 ha (#1225)
1631c77
cdcabrera pushed a commit that referenced this pull request Nov 2, 2023
@Sgitario @cdcabrera
feat(config): sw-1890 activate rhel for x86 ha (#1225)
23c42de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcabrera cdcabrera cdcabrera approved these changes

@vbusch vbusch vbusch approved these changes

Assignees
No one assigned
Labels
202312 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sgitario @vbusch @cdcabrera