Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redux): npm updates #1258

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 22, 2024

What's included

  • fix(redux): npm updates

Notes

  • isolates the redux updates since they required a different review before merging
  • there's a slight bit of concern around the peer deps that consoledot packages require, specifically around notifications and the versions of redux... still reviewing

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing, related #1257 #1256

@cdcabrera cdcabrera added build 202404 project phase labels Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Merging #1258 (5ece0c6) into main (af91893) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         122      122           
  Lines        4293     4293           
  Branches     1802     1802           
=======================================
  Hits         3946     3946           
  Misses        327      327           
  Partials       20       20           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af91893...5ece0c6. Read the comment docs.

@cdcabrera cdcabrera force-pushed the 20240123-npm-updates-redux branch 2 times, most recently from 4230812 to 93e12e1 Compare January 23, 2024 18:11
@cdcabrera cdcabrera force-pushed the 20240123-npm-updates-redux branch from 93e12e1 to 5ece0c6 Compare January 24, 2024 14:45
@cdcabrera cdcabrera marked this pull request as ready for review January 24, 2024 14:45
@cdcabrera cdcabrera merged commit 2ea350a into RedHatInsights:main Jan 25, 2024
5 of 7 checks passed
cdcabrera added a commit that referenced this pull request Jan 31, 2024
* middleware, named thunk import
* store, switch to legacy store import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants