Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(redux): merge action types, single file #1260

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 23, 2024

What's included

  • refactor(redux): merge action types, single file
  • chore(rhsmServices): optin response example
  • build(actions): issue exceptions, add refactor

Notes

  • merges redux action types into a single file. originally we thought there were going to be many many more
  • expands optin examples for testing locally

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added tech debt We've ignored it this long... 202404 project phase labels Jan 23, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
@cdcabrera cdcabrera force-pushed the 20240124-redux-actiontypes branch from d646333 to be73246 Compare January 24, 2024 15:32
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
@cdcabrera cdcabrera force-pushed the 20240124-redux-actiontypes branch from be73246 to 5225e01 Compare January 24, 2024 15:44
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
@cdcabrera cdcabrera force-pushed the 20240124-redux-actiontypes branch from 5225e01 to 25dd1d6 Compare January 24, 2024 15:50
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 24, 2024
@cdcabrera cdcabrera force-pushed the 20240124-redux-actiontypes branch from 25dd1d6 to 159d565 Compare January 25, 2024 18:40
@cdcabrera cdcabrera marked this pull request as ready for review January 25, 2024 18:40
@cdcabrera cdcabrera merged commit 8ce222e into RedHatInsights:main Jan 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202404 project phase tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant