Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sw-2410 migrate spec viewer to npm script #1382

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • build: sw-2410 migrate spec viewer to npm script

Notes

  • clean up older build spec viewer, prefer simplistic browser open with spec file ref

How to test

Confirm the spec opens

  1. $ npm run api:spec
    • confirm this opens a browser window with the spec file displaying
  2. $ npm run api:spec2
    • confirm this opens a browser window with the spec file displaying

Example

...

Updates issue/story

related to work from sw-2410

@cdcabrera cdcabrera added the 202408 project phase label Aug 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (9c998d9) to head (d9bbb44).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         115      115           
  Lines        4560     4560           
  Branches     1930     1930           
=======================================
  Hits         4174     4174           
  Misses        358      358           
  Partials       28       28           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c998d9...d9bbb44. Read the comment docs.

@cdcabrera cdcabrera merged commit 58d9367 into RedHatInsights:main Aug 6, 2024
5 of 7 checks passed
@cdcabrera cdcabrera mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants