Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sw-2410 api v2 for subscriptions inventory #1383

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 6, 2024

What's included

  • refactor: sw-2410 api v2 for subscriptions inventory

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean
    • we removed v1 properties like "metric_id" and "total_capacity"

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. confirm the subscriptions inventory for the following variants displays as intended
    • OpenShift Container
    • RHEL for x86 and related variants

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-2410

@cdcabrera cdcabrera added the 202408 project phase label Aug 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (58d9367) to head (29f0ef4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1383      +/-   ##
==========================================
- Coverage   91.53%   91.52%   -0.02%     
==========================================
  Files         115      115              
  Lines        4560     4554       -6     
  Branches     1930     1930              
==========================================
- Hits         4174     4168       -6     
  Misses        358      358              
  Partials       28       28              
Files Coverage Δ
src/config/product.openshiftContainer.js 75.47% <100.00%> (-0.90%) ⬇️
src/config/product.rhel.js 78.26% <100.00%> (-0.47%) ⬇️
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/services/rhsm/rhsmTransformers.js 100.00% <100.00%> (ø)
src/services/user/userServices.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d9367...29f0ef4. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review August 6, 2024 19:31
@cdcabrera cdcabrera merged commit b9a5d8f into RedHatInsights:main Aug 7, 2024
5 of 7 checks passed
@cdcabrera cdcabrera mentioned this pull request Aug 16, 2024
cdcabrera added a commit that referenced this pull request Aug 16, 2024
* dotenv, v2 api path updated
* config, metrics for rhel and openshift container product views
* rhsm and userServices, v2 subs mock updates
* rhsmConstants, removed deprecated props
* rhsmTransformers, consume v2 subs response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants