Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbar): sw-2856 hide residual reset filters link #1394

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

cdcabrera
Copy link
Member

What's included

fix(toolbar): sw-2856 hide residual reset filters link

Notes

  • Minor display bug around hiding the "reset filters" chips/token link when switching products via the left nav
  • Unclear how long this has been an issue
  • Fixed by simply applying a cache busting key using the internal productGroup on the react components

How to test

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. Select the RHEL product display
    • Select the toolbar filter "Type", then choose any option and let the page load
    • From the left navigation select OpenShift
    • Observe the toolbar link "Reset filters" DOES NOT display without any "chips/tokens" in front of it

Example

...

Updates issue/story

sw-2856

@cdcabrera cdcabrera added bug Something isn't working 202412 project phase labels Aug 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (c7f8313) to head (30cc8df).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         115      115           
  Lines        4554     4555    +1     
  Branches     1930     1930           
=======================================
+ Hits         4168     4169    +1     
  Misses        358      358           
  Partials       28       28           
Files Coverage Δ
src/components/toolbar/toolbar.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f8313...30cc8df. Read the comment docs.

@cdcabrera cdcabrera merged commit be3cd37 into RedHatInsights:main Aug 27, 2024
5 of 7 checks passed
@cdcabrera cdcabrera mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants