Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): issues/218 apply stable deploy paths #222

Merged
merged 2 commits into from
Mar 23, 2020
Merged

chore(build): issues/218 apply stable deploy paths #222

merged 2 commits into from
Mar 23, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 12, 2020 •
edited
Loading

What's included

  • fix(routerHelpers): issues/218 dynamic base name tests
    • in addition to beta path, include root path checks
  • chore(build): issues/218 apply stable deploy paths
    • pre script, minor local variable rename to avoid confusion
    • proxy run, stable path additions for spandx config, local run
    • custom release, beta and stable branches for ci, qa, prod

Notes

  • After this change merges, AND ANY OTHER EXISTING PR MERGES, the following git level actions need to take place i.e. Production Increment 0.1.12 #221
    • the ci branch is retained, and continues deploying to ci-beta and qa-beta
    • a qa branch has been created from the ci branch and deploys to qa-stable and ci-stable
    • master branch retains its representation as production, or what will be known as prod-stable in the future
      • It should be noted that a prod-stable update will not happen until these changes are merged into master branch
    • OPTIONAL, a stage branch has been created from the master branch and deploys to prod-beta

How to test

Example

...

Updates issue/story

Updates #218
Closes #144

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 12, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
e908ac0 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 12, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
b47163e 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 12, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
e19b93d 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@codecov-io
Copy link

codecov-io commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #222 into ci will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #222   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          42       42           
  Lines         837      837           
  Branches      207      207           
=======================================
  Hits          776      776           
  Misses         57       57           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a2fab...f328c37. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 13, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
ac69b0c 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 13, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
6ad5695 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 13, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
e9468a8 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@cdcabrera cdcabrera force-pushed the ci branch 2 times, most recently from ca2b196 to fd4f457 Compare March 19, 2020 20:41
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 19, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
d55bbdf 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@cdcabrera cdcabrera changed the title WIP chore(build): issues/218 apply stable deploy paths chore(build): issues/218 apply stable deploy paths Mar 19, 2020
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 20, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
7dd3f26 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@cdcabrera
fix(routerHelpers): issues/218 dynamic base name tests
94fdf54 
* in addition to beta path, include root path checks
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 23, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
acc1ae5 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 23, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
48eb9a2 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@cdcabrera
chore(build): issues/218 apply stable deploy paths (RedHatInsights#222)
f328c37 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
@cdcabrera cdcabrera merged commit c9f76be into RedHatInsights:ci Mar 23, 2020
cdcabrera added a commit that referenced this pull request Apr 2, 2020
@cdcabrera
chore(build): issues/218 apply stable deploy paths (#222)
88c9a99 
* pre.sh, minor local variable rename to avoid confusion
* proxy run, stable path additions for spandx config, local run
* contributing.md, branch and pr workflow updated
* custom release, beta and stable branches for ci, qa, prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-io