Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/240 - Platform services debugging, auth empty state, and translate a node #250

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 9, 2020

What's included

  • fix(platformServices): issue/240 admin API debugging behavior
  • fix(authentication,messageView): auth empty state

    • authentication, update auth empty state
    • messageView, add pageTitle prop
  • feat(i18n): issues/240 expose translating a node

    • helpers, noopTranslate
    • i18n, add node translate, annotations

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

Screen Shot 2020-04-09 at 6 54 00 PM

Updates issue/story

#240
relates #291

* authentication, update auth empty state
* messageView, add pageTitle prop
* helpers, noopTranslate
* i18n, add node translate, annotations
@cdcabrera cdcabrera merged commit 0b96389 into RedHatInsights:ci Apr 9, 2020
@cdcabrera cdcabrera mentioned this pull request Apr 10, 2020
cdcabrera added a commit that referenced this pull request Apr 10, 2020
* helpers, noopTranslate
* i18n, add node translate, annotations
@cdcabrera cdcabrera mentioned this pull request Apr 10, 2020
cdcabrera added a commit that referenced this pull request Apr 17, 2020
* helpers, noopTranslate
* i18n, add node translate, annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant