Opt-in API error code and platform user permissions #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ci #277 +/- ##
==========================================
- Coverage 92.36% 92.31% -0.06%
==========================================
Files 47 47
Lines 1022 1028 +6
Branches 240 245 +5
==========================================
+ Hits 944 949 +5
- Misses 72 73 +1
Partials 6 6
Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 8, 2020
…s#277) * userReducer, expose API error codes * rhsmApiTypes, add API error response types
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 8, 2020
…s#277) * userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 8, 2020
* authentication, optin error code check * i18n test
cdcabrera
force-pushed
the
issues/260
branch
2 times, most recently
from
f9da761 to
850d88d
Compare
cdcabrera
changed the title
cdcabrera
force-pushed
the
ci
branch
2 times, most recently
from
7e13684 to
0cf1afc
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 8, 2020
…s#277) * userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
* userReducer, map user permissions * platformServices, remove user permissions async/await, name param * platformApiTypes, user permission types
* reduxHelpers, expose error data correctly, expand test checks * statusMiddleware, payload restructure, add data to dispatch * userReducer, reduxHelper http status check
…s#277) * userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
* authentication, optin error code check * i18n test
cdcabrera
added a commit
that referenced
this pull request
May 8, 2020
* userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
Merged
cdcabrera
added a commit
that referenced
this pull request
May 19, 2020
* userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
Merged
cdcabrera
added a commit
that referenced
this pull request
May 20, 2020
* userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
cdcabrera
added a commit
that referenced
this pull request
May 20, 2020
* userReducer, expose API error codes * rhsmApiTypes, add API error response types * rhsmServices, mock for 403 and error code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Local run check
$ yarn$ yarn startand the browser should open49in./src/services/rhsmServicesfromIf you have Redux logging setup, you can also confirm by opening the developer browser console and checking the last Redux state update. You should be able to expand the
userobject and see theerrorCodeforopt in,SUBSCRIPTIONS1004Example
...
Updates issue/story
#260