Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(productView): issues/524 display satellite #538

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Dec 14, 2020

What's included

  • feat(productView): issues/524 display satellite
    • locale, satellite strings
    • productView, basic product display
    • productViewSatellite, apply satellite to basic display
    • routerTypes, satellite routing
    • rhsmApiTypes, satellite products

Notes

  • the productView component provides a basic display for products. Next steps for this include moving the RHEL product to this format since it is currently "similar", if not the exact same, to Satellite 6... short of any product requirements/alterations we have not been informed of
    • the visual differences and components between Satellite and RHEL are the same, the only differences currently are in the Product IDs and associated display strings
    • @joeldmyers it isn't necessary to convert over to this format as part of the #491 issue until we've confirmed this component breakout isn't nightmare'ish to maintain
  • to access the Satellite product views you currently have to manually type in routes, LEFT NAV IS NOT ACTIVE on purpose
    • [CI]/beta/subscriptions/satellite-sw/all
    • [CI]/beta/subscriptions/satellite-sw/capsule
  • @jlprevatt @ntkathole we're a little unclear if Sat 6 Capsule is meant to be an "architecture". A view can be created easily if needed

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to the following routes
    • /beta/subscriptions/satellite-sw/all
    • /beta/subscriptions/satellite-sw/capsule
  5. confirm no browser errors are present, and the the related title and the graph tooltip and legend copy accurately relates "Satellite"

Example

Screen Shot 2020-12-14 at 5 56 49 PM

Updates issue/story

#524

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #538 (d6e92ca) into ci (bbae1d2) will decrease coverage by 0.18%.
The diff coverage is 86.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #538      +/-   ##
==========================================
- Coverage   93.32%   93.14%   -0.19%     
==========================================
  Files          80       82       +2     
  Lines        2113     2625     +512     
  Branches      533      910     +377     
==========================================
+ Hits         1972     2445     +473     
- Misses        119      157      +38     
- Partials       22       23       +1     
Impacted Files Coverage Δ
src/components/router/routerTypes.js 50.00% <0.00%> (-10.00%) ⬇️
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/components/productView/productViewSatellite.js 85.71% <85.71%> (ø)
src/components/productView/productView.js 100.00% <100.00%> (ø)
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
...s/inventorySubscriptions/inventorySubscriptions.js 89.83% <0.00%> (-2.86%) ⬇️
src/redux/selectors/subscriptionsListSelectors.js 97.22% <0.00%> (-2.78%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.50% <0.00%> (-2.50%) ⬇️
src/components/inventoryList/inventoryList.js 90.90% <0.00%> (-2.43%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbae1d2...d6e92ca. Read the comment docs.

src/components/productView/productView.js Outdated Show resolved Hide resolved
src/components/productView/productViewSatellite.js Outdated Show resolved Hide resolved
src/types/rhsmApiTypes.js Show resolved Hide resolved
* locale, satellite strings
* productView, basic product display
* productViewSatellite, apply satellite to basic display
* routerTypes, satellite routing
* rhsmApiTypes, satellite products
@cdcabrera cdcabrera merged commit 9ad5385 into RedHatInsights:ci Dec 15, 2020
cdcabrera added a commit that referenced this pull request Dec 15, 2020
* locale, satellite strings
* productView, basic product display
* productViewSatellite, apply satellite to basic display
* routerTypes, satellite routing
* rhsmApiTypes, satellite products
cdcabrera added a commit that referenced this pull request Jan 27, 2021
* locale, satellite strings
* productView, basic product display
* productViewSatellite, apply satellite to basic display
* routerTypes, satellite routing
* rhsmApiTypes, satellite products
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* locale, satellite strings
* productView, basic product display
* productViewSatellite, apply satellite to basic display
* routerTypes, satellite routing
* rhsmApiTypes, satellite products
cdcabrera added a commit that referenced this pull request Feb 16, 2021
* locale, satellite strings
* productView, basic product display
* productViewSatellite, apply satellite to basic display
* routerTypes, satellite routing
* rhsmApiTypes, satellite products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants