Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump actions/setup-node from 2.3.0 to 2.4.0 #784

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2021

Bumps actions/setup-node from 2.3.0 to 2.4.0.

Release notes

Sourced from actions/setup-node's releases.

Support caching for mono repos and repositories with complex structure

This release introduces dependency caching support for mono repos and repositories with complex structure (#305).

By default, the action searches for the dependency file (package-lock.json or yarn.lock) in the repository root. Use the cache-dependency-path input for cases when multiple dependency files are used, or they are located in different subdirectories. This input supports wildcards or a list of file names for caching multiple dependencies.

Yaml example:

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
  with:
    node-version: 14
    cache: npm
    cache-dependency-path: 'sub-project/package-lock.json'

For more examples of using cache-dependency-path input, see the Advanced usage guide.

Revert temporary fix

We had to disable pre-cached Node.js usage in the previous version due to the broken image cache. Now cache is fixed, so we can safely enable its usage again. Thank you for understanding.

Temporary maintenance fix.

Temporarily disabled usage of pre-cached Node.js.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the build label Sep 1, 2021
@cdcabrera
Copy link
Member

cdcabrera commented Sep 2, 2021

Have to review and run testing off to the side on the new "caching" ability to see how it overlaps how we coded something similar.

THIS PR SHOULD NOT BE MERGED UNTIL TESTING IS COMPLETED

@cdcabrera cdcabrera added the blocked Prevented from continuing label Sep 2, 2021
@cdcabrera
Copy link
Member

@dependabot rebase

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Sep 7, 2021
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/ci/actions/setup-node-2.4.0 branch from abf95a8 to 6c8209a Compare September 7, 2021 16:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #784 (6c8209a) into ci (e8d9f7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #784   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         101      101           
  Lines        2838     2838           
  Branches     1034     1034           
=======================================
  Hits         2705     2705           
  Misses        125      125           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d9f7c...6c8209a. Read the comment docs.

@cdcabrera
Copy link
Member

The caching is optional we can keep our current way of handling it or attempt to use the baked in version. Testing the baked in cache with #789

@cdcabrera cdcabrera added the blocked Prevented from continuing label Sep 7, 2021
@cdcabrera
Copy link
Member

Appears as of 20210907 GitHub actions is experiencing "degraded" service. We'll hold on merging this until performance is back... the output randomly keeps saying it's setting up

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Sep 7, 2021
@cdcabrera
Copy link
Member

After reviewing a little bit further, #789 will be a follow up PR to this one where we'll implement the baked in caching for actions/setup-node and retain our existing node modules cache. The baked in stuff does let us remove our version of it with a one-liner. But without the node modules cache we end up adding another 25-30 seconds to the process, which doesn't necessarily sound like much except when you're waiting after additional commits are pushed onto a PR.

@cdcabrera cdcabrera merged commit e5795b5 into ci Sep 7, 2021
@dependabot dependabot bot deleted the dependabot/github_actions/ci/actions/setup-node-2.4.0 branch September 7, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants