Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes): ent-4366 update product path id #826

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 9, 2021

What's included

  • fix(routes): ent-4366 update product path id

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the rhosak display is accessible via /subscriptions/streams

Example

...

Updates issue/story

ENT-4366

@cdcabrera cdcabrera added story New feature, or process work 202112 project phase labels Nov 9, 2021
@cdcabrera
Copy link
Member Author

Looks like we came across the first issue with using other products to describe products... the missing product view we use groups

  • OpenShift Dedicated
  • OpenShift Metrics
  • OpenShift Container
  • and of course OpenShift Streams

This is the warning sign, it may be manageable now... and we can fix the logic for RHOSAK, but the more products we add the more conflicts we'll have. We're tempted to implement some level of product path hash to go around this entirely

@cdcabrera cdcabrera force-pushed the ent-4366-rhosak-routing branch from 10c9d70 to a0c0e03 Compare November 10, 2021 22:41
@cdcabrera cdcabrera force-pushed the ent-4366-rhosak-routing branch 2 times, most recently from 63b56f7 to b10d692 Compare November 11, 2021 15:42
@cdcabrera cdcabrera merged commit 4a02667 into RedHatInsights:ci Nov 11, 2021
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* routes, use streams alias for rhosak
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* routes, use streams alias for rhosak
cdcabrera added a commit that referenced this pull request Nov 30, 2021
* routes, use streams alias for rhosak
cdcabrera added a commit that referenced this pull request Dec 6, 2021
* routes, use streams alias for rhosak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant