Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chartHelpers): ent-4366 adjust yaxis domain for small values #839

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(chartHelpers): ent-4366 adjust yaxis domain for small values

Notes

  • Clean up PR targeted at a better UX
  • Adjusts the y axis domain range for smaller values. Our cutoff for displaying small values was 0.01 we moved it to 0.1 because during testing a value came through in the graph rightttttt above 0.01 just enough to not fire the logic and just enough to look really minuscule on the graph

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. find an account that has a max Y value for the entire month above and below 0.1... the graph should adjust accordingly. If there are any other Y values greater those will be used instead.

Example

...

Updates issue/story

ent-4366

@cdcabrera cdcabrera added the 202112 project phase label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant