Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates, regen lock #887

Merged
merged 5 commits into from
Feb 22, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 21, 2022

What's included

  • fix(build): npm updates, regen lock
  • fix(testing): clean up fragment wrappers

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm all tests pass

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm local run is still functioning

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm proxy run is still functioning

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm build compiles and tests pass

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added the 202204 project phase label Feb 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #887 (c005fc3) into ci (fdeccfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #887   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         126      126           
  Lines        3692     3692           
  Branches     1445     1445           
=======================================
  Hits         3473     3473           
  Misses        201      201           
  Partials       18       18           
Impacted Files Coverage Δ
src/redux/selectors/graphCardSelectors.js 98.27% <ø> (ø)
src/redux/selectors/inventoryListSelectors.js 97.29% <ø> (ø)
src/services/config.js 85.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdeccfb...c005fc3. Read the comment docs.

@cdcabrera cdcabrera merged commit f98fcb5 into RedHatInsights:ci Feb 22, 2022
cdcabrera added a commit that referenced this pull request Mar 1, 2022
@cdcabrera cdcabrera mentioned this pull request Mar 3, 2022
cdcabrera added a commit that referenced this pull request Mar 8, 2022
cdcabrera added a commit that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants