Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(userServices): ent-4669 locale func #913

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

cdcabrera
Copy link
Member

What's included

  • refactor(userServices): ent-4669 locale func
  • feat(serviceConfig): ent-4669 timeout for emulated call
  • feat(helpers): ent-4669 aggregate error

Notes

  • minor helper updates, broken out from the larger session work to provide some incremental updates
  • no visual changes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm GUI loads without direct error

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

ent-4669

@cdcabrera cdcabrera added the 202204 project phase label Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #913 (af370aa) into ci (3f563e6) will increase coverage by 0.00%.
The diff coverage is 97.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #913   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         129      129           
  Lines        3745     3764   +19     
  Branches     1469     1474    +5     
=======================================
+ Hits         3535     3553   +18     
- Misses        194      195    +1     
  Partials       16       16           
Impacted Files Coverage Δ
src/common/helpers.js 98.33% <90.00%> (-1.67%) ⬇️
src/services/common/helpers.js 89.74% <100.00%> (+4.55%) ⬆️
src/services/common/serviceConfig.js 98.83% <100.00%> (ø)
src/services/user/userServices.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f563e6...af370aa. Read the comment docs.

@cdcabrera cdcabrera merged commit 30cd756 into RedHatInsights:ci Mar 28, 2022
cdcabrera added a commit that referenced this pull request Mar 28, 2022
cdcabrera added a commit that referenced this pull request Apr 14, 2022
@cdcabrera cdcabrera mentioned this pull request Apr 14, 2022
cdcabrera added a commit that referenced this pull request Apr 19, 2022
cdcabrera added a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants