Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhsmTransformers): ent-5121 hide graph future dates #948

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 24, 2022

What's included

  • fix(rhsmTransformers): ent-5121 hide graph future dates

Notes

  • Hides both ... future dates that has data = false AND the current UTC date if has data = false
  • DOES NOT HIDE past dates that have has data = false
  • applies unit testing behavior confirmations in the event "granularity" ever shifts from daily

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the graph display for RHOSAK are hiding future dates with has data = false, see examples below
  5. confirm the graph displays for RHOSAK are hiding current dates with has data = false, see examples below

Example

Hide current AND future dates

Screen Shot 2022-06-23 at 9 53 07 PM
Screen Shot 2022-06-23 at 9 53 21 PM
Screen Shot 2022-06-23 at 9 53 29 PM

ONLY hide future dates

Screen Shot 2022-06-23 at 10 14 33 PM

Screen Shot 2022-06-23 at 10 14 58 PM
Screen Shot 2022-06-23 at 10 15 09 PM

Updates issue/story

ent-5121

@cdcabrera cdcabrera added the 202208 project phase label Jun 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #948 (0f63c84) into ci (3ef53f5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #948      +/-   ##
==========================================
+ Coverage   94.05%   94.08%   +0.03%     
==========================================
  Files         129      129              
  Lines        4020     4025       +5     
  Branches     1571     1572       +1     
==========================================
+ Hits         3781     3787       +6     
+ Misses        221      220       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/services/rhsm/rhsmTransformers.js 100.00% <100.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef53f5...0f63c84. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants