Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): SW-460 dev standalone local run #957

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 26, 2022

What's included

  • fix(build): SW-460 dev standalone local run
  • fix(toolbarContext): keys for secondary fields

Notes

  • Reverts the keycloak mock updates, and opts towards our old standalone local run with minimal styling. The advantage is we need zero network connections, outside of the repo, to develop. Relates fix(build): keycloak for local run #954

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the application loads
  4. you'll need to manually navigate towards products by updating the paths (this is expected, and how it used to be)

Example

...

Updates issue/story

SWATCH-460
#954
dependency on #958

@cdcabrera cdcabrera added the 202208 project phase label Jul 26, 2022
* build, revert mock keycloak changes RedHatInsights#954
* build, apply CRA updates for standalone run
* routerHelpers, redirect, convert path func
@cdcabrera cdcabrera force-pushed the swatch-460-localrun branch from 51f8b89 to c6f7acc Compare July 27, 2022 16:17
@cdcabrera cdcabrera marked this pull request as ready for review July 27, 2022 16:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #957 (c6f7acc) into dev (9fec20c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #957      +/-   ##
==========================================
+ Coverage   93.92%   93.96%   +0.03%     
==========================================
  Files         129      129              
  Lines        4036     4044       +8     
  Branches     1580     1583       +3     
==========================================
+ Hits         3791     3800       +9     
+ Misses        227      226       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/services/platform/platformServices.js 98.14% <ø> (ø)
src/common/helpers.js 100.00% <100.00%> (+1.66%) ⬆️
src/components/router/redirect.js 100.00% <100.00%> (ø)
src/components/router/routerHelpers.js 98.80% <100.00%> (+0.10%) ⬆️
src/components/toolbar/toolbarContext.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fec20c...c6f7acc. Read the comment docs.

@cdcabrera cdcabrera merged commit 71504ff into RedHatInsights:dev Jul 27, 2022
cdcabrera added a commit that referenced this pull request Jul 27, 2022
* build, revert mock keycloak changes #954
* build, apply CRA updates for standalone run
* routerHelpers, redirect, convert path func
cdcabrera added a commit that referenced this pull request Aug 1, 2022
* build, revert mock keycloak changes #954
* build, apply CRA updates for standalone run
* routerHelpers, redirect, convert path func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants