Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serviceConfig): sw-630 hash for cache, cancel #996

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 4, 2022

What's included

  • feat(serviceConfig): sw-630 hash for cache, cancel

Notes

  • flips to using a package to generate a consistent hash used for service response caching and cancelling
  • needed for future proofing the use of "category" in query
  • non-visual update

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the product views still function as intended

Example

...

Updates issue/story

relates sw-630

* build, crypto npm, generate hash
* helpers, func generateHash, sha1
* services, passthrough, config hash
@cdcabrera cdcabrera force-pushed the sw-223-630-graph-inventory branch from f70835d to d71b348 Compare November 4, 2022 16:01
@cdcabrera cdcabrera added the 202212 project phase label Nov 4, 2022
@cdcabrera cdcabrera marked this pull request as ready for review November 4, 2022 16:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #996 (d71b348) into dev (962c973) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #996   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files         130      130           
  Lines        4125     4126    +1     
  Branches     1631     1628    -3     
=======================================
+ Hits         3870     3871    +1     
  Misses        237      237           
  Partials       18       18           
Impacted Files Coverage Δ
src/common/helpers.js 100.00% <100.00%> (ø)
src/services/common/helpers.js 92.50% <100.00%> (+0.19%) ⬆️
src/services/common/serviceConfig.js 98.70% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962c973...d71b348. Read the comment docs.

@cdcabrera cdcabrera merged commit bf50259 into RedHatInsights:dev Nov 4, 2022
cdcabrera added a commit that referenced this pull request Nov 8, 2022
* build, crypto npm, generate hash
* helpers, func generateHash, sha1
* services, passthrough, config hash
cdcabrera added a commit that referenced this pull request Dec 5, 2022
* build, crypto npm, generate hash
* helpers, func generateHash, sha1
* services, passthrough, config hash
cdcabrera added a commit that referenced this pull request Dec 5, 2022
* build, crypto npm, generate hash
* helpers, func generateHash, sha1
* services, passthrough, config hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202212 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants