Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tls security compliance #125

Conversation

aleccohan
Copy link
Contributor

@aleccohan aleccohan commented May 3, 2023

Update sentry-dsn to glitchtip-dsn

  • Update logging logic for dsn to use glitchtip instead of sentry

Upgrade golang version for project from 1.12 → 1.19Seat Management

  • Created “/seats” and “/seats/{id}” endpoints
    New API to interact with AMS for consuming quota (primarilly for Ansible)

Clowderize Entitlements

  • Previously Entitlements was not clowderized since it wasn’t in scope with the “initial” clowderization push
    Added clowdapp.yml for Entitlements
    This also allows us to use Envoy TLS instead of hardcoding TLS for Entitlements

Additional less impactful changes

  • Updates to the ReadME

Re-name environment variables

  • AMS_URL → AMS_HOST

abaiken and others added 15 commits April 4, 2023 16:18
* Update sentry-dsn to glitchtip-dsn

* add default value

* fix line

* Make sure log messages are clear that we are using glitchtip dsn
* goland upgrade into 1.19 and sentry-go package update into v0.20.0

---------

Co-authored-by: Daniel Agbay <dagbay@redhat.com>
* pulling in ocm client wrapper

* adding some types and errors

* generating seats with oapi generator

* using server generation for seats

* generate into api dir

* moving to a Makefile

* adding in error handling

* wiring in more client operations

* wiring tests to makefile

* fixing generator version and adding more tests

* checking limits on list

* filling in links data

* go 1.19 is required for our deps, using official builder as a result

* adding default token url

* updating travis to use 1.19

* adding some metrics

* update to go1.19 for seat management (RedHatInsights#107)

* [RHCLOUD-23259] Update sentry-dsn to glitchtip-dsn (RedHatInsights#101)

* Update sentry-dsn to glitchtip-dsn

* add default value

* fix line

* Make sure log messages are clear that we are using glitchtip dsn

* Initialize the dsn (RedHatInsights#102)

* [RHCLOUD-25196] Golang upgrade into 1.19 (RedHatInsights#106)

* goland upgrade into 1.19 and sentry-go package update into v0.20.0

---------

Co-authored-by: Daniel Agbay <dagbay@redhat.com>

* changed name of config file to be aligned with other steps in readme file (RedHatInsights#105)

---------

Co-authored-by: Ashley Aiken <aaiken@redhat.com>
Co-authored-by: Petra Cihalova <89980168+petracihalova@users.noreply.github.com>

* need to request a count

* stubbing out back office proxy client

* adding in bop client and org id check

* fixing up some of the ams calls

* filling out bop client code

* fixed a couple bugs with assigning and listing seats

* post doesn't return the username, so just use the one we sent

* adding more tests

* added log in ams when a 500 happens, and validated bop settings when creating client

* error context (RedHatInsights#110)

* added context to errors around calls to BOP

* must return here to properly bail out

* adding new config to deployment manifest

* updated entitlements secret ref name

* handling the case where the request is denied

* wrap seat request json decode error

* some error handling around call to bop, add log level to deploy template (RedHatInsights#111)

* added info to bop error

* added error context to GetUser in bop client

* factored out log level to an env variable

* renamed method

* added ability to set custom mock bop getuser response

* added error handling around get user request to bop

* removed http test server

* unwrap QuotaAuthorizationResponse in ams client quota authorization

---------

Co-authored-by: Daniel Agbay <101584191+dagbay-rh@users.noreply.github.com>
Co-authored-by: Ashley Aiken <aaiken@redhat.com>
Co-authored-by: Petra Cihalova <89980168+petracihalova@users.noreply.github.com>
Co-authored-by: Daniel Agbay <dagbay@redhat.com>
* added context around error logs in ams controller

* add debug log around org id conversion

* add debug log around getting ams org id from cache
* added context around error logs in ams controller

* add debug log around org id conversion

* add debug log around getting ams org id from cache

* changing log levels to info temporarily
* Push clowdapp.yml file for Entitlements Clowderization

* Update Cloudwatch to pull from clowder acgConfig

* remove optional dependencies from clowdapp.yaml

* Get app-common-go package

* Remove secret pulls that we don't need anymore
* return error if ams org id is not found

* changed log message

* handle ams client errors in controller

* switch logs back to debug
* Add additional env vars to clowder.yml file

* remove formating error

* update formating
- resolve indentation issues
- update probe ports
- add `ENV_NAME` for clowder
- update `envFrom` to `valueFrom` (was having issues in deploying)
- setup `default-entitlements-config` volume
- `API_REPLICAS` to `REPLICAS`
@aleccohan aleccohan marked this pull request as ready for review May 5, 2023 17:28
Copy link
Contributor

@casey-williams-rh casey-williams-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aleccohan aleccohan merged commit 792d242 into RedHatInsights:security-compliance May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants