Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version to 1.21 #162

Closed
wants to merge 8 commits into from

Conversation

dagbay-rh
Copy link
Contributor

@dagbay-rh dagbay-rh commented Jan 15, 2024

Summary

  • update go to version 1.21

Why

We are currently on version 1.19, so this just bumps us up to the current release of go

Testing

  • successfully ran go mod tidy and go get ./... and built/ran the service locally via make && make exe
  • hit all of our endpoints locally and they all worked fine
  • ran unit tests, all work
  • pipeline build is successful

@dagbay-rh
Copy link
Contributor Author

our jenkins nodes might be lacking support for go1.21, pr check failing because of this:

19:25:20 controllers/subscriptions.go:10:2: package slices is not in GOROOT (/usr/lib/golang/src/slices)
19:25:20 note: imported by a module that requires go 1.21
19:25:20 make: *** [test-all] Error 1

@dagbay-rh dagbay-rh mentioned this pull request Jan 17, 2024
4 tasks
@dagbay-rh
Copy link
Contributor Author

our jenkins nodes the pr check runs on only supports up to go1.20 right now. closing this pr in favor of this new pr to bump us to 1.20 for now: #163

@dagbay-rh dagbay-rh closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant