Switching to webpack-serve. There were a number of hot reload issues with WDS #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made the same changes here... https://github.com/RedHatInsights/turbo-octo-couscous/tree/fixes/webpack-serve That worked well, pulling them over to this repo. Can you test locally and make sure that the hot reload stuff works for you? |
iphands
force-pushed
the
fixes/webpack-serve
branch
from
1b71075 to
bacf85a
Compare
|
Hot reload works as before. Tried adding some simple string somewhere and console logged it, same with importing newly created file. I'll open new PR which fixes the test build so this could be merged without breaking the CI. |
iphands
force-pushed
the
fixes/webpack-serve
branch
from
bacf85a to
da36107
Compare
iphands
force-pushed
the
fixes/webpack-serve
branch
from
18225a1 to
a89a4bc
Compare
Kinlaw
pushed a commit
that referenced
this pull request
Oct 31, 2018
…date Enhancements/pf4 layout update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack Dev Server had some bad issues with their websocket for hot reloading setup.
They made some assumptions about what the servers base URL, HOST, and PORT and this was not configurable by the user.
This made the hot reloading features fail hard when used through a proxy like insights-proxy
See: webpack/webpack-dev-server#1289
webpack-serve does not have these same issues