Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for node12 support #77

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Update deps for node12 support #77

merged 2 commits into from
Sep 23, 2019

Conversation

shdunning
Copy link
Contributor

@shdunning shdunning requested a review from ryelo September 20, 2019 19:11
karelhala
karelhala requested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just a minor update is required - no need for fsevents and nan in package.json we are not using them anywhere, so we don't have to decare their version.

@shdunning
Copy link
Contributor Author

@karelhala done - good catch!

@codecov-io
Copy link

codecov-io commented Sep 23, 2019 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   16.92%   16.92%           
=======================================
  Files          12       12           
  Lines          65       65           
  Branches        5        5           
=======================================
  Hits           11       11           
  Misses         51       51           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da690c0...4e14fe6. Read the comment docs.

karelhala
karelhala approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@karelhala karelhala merged commit 9bfa154 into master Sep 23, 2019
@Hyperkid123 Hyperkid123 deleted the SupportForNode12 branch August 2, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@ryelo ryelo Awaiting requested review from ryelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shdunning @codecov-io @karelhala