Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DVO publisher #108

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

joselsegura
Copy link
Collaborator

Description

Adding DVO Publisher and its tests

Fixes #CCXDEV-11585

Type of change

  • New feature (non-breaking change which adds functionality)
  • Unit tests (no changes in the code)

Testing steps

Tested locally

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f561c3) 86.03% compared to head (ad5744e) 86.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   86.03%   86.59%   +0.56%     
==========================================
  Files          23       24       +1     
  Lines         666      694      +28     
==========================================
+ Hits          573      601      +28     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joselsegura joselsegura merged commit 1162030 into RedHatInsights:main Nov 20, 2023
6 checks passed
@joselsegura joselsegura deleted the ccxdev-11585 branch November 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants