Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all Kafka bootstrap servers from Clowder config #122

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Nov 30, 2023

Description

Use all the provided bootstrap servers instead of just the first one

Fixes CCXDEV-11238

Type of change

  • New feature (non-breaking change which adds functionality)

Testing steps

Not fully done. The UTs developed cannot be merged (75ff4f1), but I'll keep working on it when I have some time

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e0994cd) 85.77% compared to head (9c8dce0) 92.01%.
Report is 4 commits behind head on main.

Files Patch % Lines
ccx_messaging/utils/clowder.py 90.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   85.77%   92.01%   +6.24%     
==========================================
  Files          24       24              
  Lines         703      739      +36     
==========================================
+ Hits          603      680      +77     
+ Misses        100       59      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epapbak epapbak force-pushed the CCXDEV-12238 branch 12 times, most recently from 5e0b9a5 to 75ff4f1 Compare December 4, 2023 12:21
@epapbak epapbak marked this pull request as ready for review December 4, 2023 12:48
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@epapbak epapbak merged commit bcaa81f into RedHatInsights:main Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants