Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using only pyproject to align with other Python projects #123

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

joselsegura
Copy link
Collaborator

Description

Going from setuptools + pbr to pyproject.toml setup to align with ccx-data-pipeline project.

Type of change

  • Refactor (refactoring code, removing useless files)
  • Bump-up dependent library (no changes in the code)

Testing steps

Just tried locally to compile the library distribution and it worked

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0994cd) 85.77% compared to head (5d2adf4) 85.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          24       24           
  Lines         703      703           
=======================================
  Hits          603      603           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joselsegura joselsegura merged commit 36e9039 into RedHatInsights:main Dec 1, 2023
6 checks passed
@joselsegura joselsegura deleted the pyproject branch December 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants